Skip to content

Conversation

@fimugdha
Copy link
Contributor

@fimugdha fimugdha commented Feb 11, 2026

What changes were proposed in this pull request?

RANGER-5490 : Bump webpack from 5.94.0 to 5.105.0 in security-admin/src/main/webapp/react-webapp/package.json.

How was this patch tested?

Tested Ranger Admin UI coming up successfully with this changes.

Successful completion of build command :
mvn clean compile package -DskipTests

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the React Admin UI build toolchain dependencies to address the requested webpack upgrade.

Changes:

  • Upgraded webpack from ^5.94.0 to ^5.105.0
  • Upgraded webpack-cli from ^5.0.0 to ^6.0.1
  • Upgraded webpack-merge from ^5.8.0 to ^6.0.1
Files not reviewed (1)
  • security-admin/src/main/webapp/react-webapp/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"webpack": "^5.94.0",
"webpack-cli": "^5.0.0",
"webpack": "^5.105.0",
"webpack-cli": "^6.0.1",
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webpack-dev-server@^5.2.2 typically has a peer dependency range that supports webpack-cli v4/v5, so bumping webpack-cli to ^6.0.1 can cause peer-dependency resolution failures (or hard install failures with strict peer deps). Consider keeping webpack-cli on ^5.x for compatibility, or bump webpack-dev-server to a version that explicitly supports webpack-cli@6.

Suggested change
"webpack-cli": "^6.0.1",
"webpack-cli": "^5.1.4",

Copilot uses AI. Check for mistakes.
"webpack-cli": "^6.0.1",
"webpack-dev-server": "^5.2.2",
"webpack-merge": "^5.8.0"
"webpack-merge": "^6.0.1"
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major-version bump (webpack-merge 5 -> 6). If the project has custom webpack config code that imports/uses webpack-merge, the API/behavior changes can break builds without any code changes in this PR. If the upgrade is required, it would help to (a) call out the compatibility/behavior change in the PR description, or (b) keep webpack-merge on ^5.x unless a corresponding config change is included.

Suggested change
"webpack-merge": "^6.0.1"
"webpack-merge": "^5.10.0"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants