Add task submodule and PR-triggered integration testing#86
Closed
luigidematteis wants to merge 7 commits intoapache:mainfrom
Closed
Add task submodule and PR-triggered integration testing#86luigidematteis wants to merge 7 commits intoapache:mainfrom
luigidematteis wants to merge 7 commits intoapache:mainfrom
Conversation
The .gitmodules file uses git config syntax which does not support license headers.
flatdict 4.0.1 only ships as a source tarball. Building it requires pkg_resources (setuptools), removed from Python 3.12 virtual environments. Version 4.1.0 ships a pre-built wheel, bypassing the build step entirely. Also update Dockerfile Poetry from 1.8.5 to 2.3.2 to match the lock-version 2.1 format already in use.
…orkflow Add task submodule and PR-triggered integration testing
Allow forks to push operator images to ghcr.io by setting the IMAGE_REGISTRY repository variable, without requiring Docker Hub credentials. Defaults to registry.hub.docker.com for backward compatibility with the Apache upstream. When DOCKERHUB_USER/DOCKERHUB_TOKEN secrets are not set, credentials fall back to github.actor/GITHUB_TOKEN automatically.
Same fix as testing repo: branches-ignore under push was causing spurious workflow runs on branch pushes. With only tags filter present, branch pushes are already excluded.
Contributor
Author
|
The CI passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
openserverless-taskas a git submodule atolaris/and introduces a workflow that lets maintainers trigger the full acceptance test suite directly from an operator PR.Task submodule (
olaris/)The operator now carries its own task definitions via a submodule pointing to
apache/openserverless-task. When the testing pipeline clones an operator PR branch with--recurse-submodules, it gets the operator code and task definitions in a single checkout.This enables:
Trigger workflow (
trigger-testing.yaml)A new workflow that dispatches
operator-pr-testevents toopenserverless-testingwhen a maintainer comments/testing <platform>on a PR.Triggers:
issue_comment: parses/testing <platform>from PR commentsworkflow_dispatch: manual trigger withpr_numberandplatforminputsGuards:
MEMBER,OWNER, orCOLLABORATOR(@msciabarra let's understand together if we need a more strict rule)Dispatches a
repository_dispatchevent to<owner>/openserverless-testingwith:pr_number,pr_ref,pr_sha— identifies the PR branchoperator_repo— the fork/repo where the PR livesplatform— the target test platform (e.g.k3s-amd)Uses
${{ github.repository_owner }}for the dispatch target, so the same workflow works on forks and upstream.Secret required
OPENSERVERLESS_TESTING_PATreposcope on the testing repo, used to firerepository_dispatcheventsCompanion PR
This PR works together with a PR on
openserverless-testingthat adds:operator-pr-test.yamlworkflow (receives the dispatch, builds the image, runs tests)apache/openserverless-testing#4
How to change the submodule pointer