MINIFICPP-2750 Fix Windows build with CMake 4#2138
Open
lordgamez wants to merge 1 commit intoapache:mainfrom
Open
MINIFICPP-2750 Fix Windows build with CMake 4#2138lordgamez wants to merge 1 commit intoapache:mainfrom
lordgamez wants to merge 1 commit intoapache:mainfrom
Conversation
CMake 4 is not compatible with CMake features in versions older than CMake 3.5. We need to specify at least version 3.5 for minimum requirements to make configuration succeed. Fortunately winflexbison does not use any older CMake features so changing the required version solves the issue.
fgerlits
reviewed
Mar 18, 2026
Comment on lines
44
to
+49
| ERROR_VARIABLE bisonbuildE | ||
| ) | ||
|
|
||
| if(NOT result EQUAL 0) | ||
| message(FATAL_ERROR "configuration failed for winflexbison:\n${bisonbuildE}") | ||
| endif() |
Contributor
There was a problem hiding this comment.
Can we use COMMAND_ERROR_IS_FATAL instead of RESULT_VARIABLE, OUTPUT_VARIABLE and ERROR_VARIABLE?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake 4 is not compatible with CMake features in versions older than CMake 3.5. We need to specify at least version 3.5 for minimum requirements to make configuration succeed. Fortunately winflexbison does not use any older CMake features so changing the required version solves the issue.
https://issues.apache.org/jira/browse/MINIFICPP-2746
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.