MINIFICPP-2718 Windows based docker tests#2133
MINIFICPP-2718 Windows based docker tests#2133martinzink wants to merge 4 commits intoapache:mainfrom
Conversation
martinzink
force-pushed
the
MINIFICPP-2718
branch
from
47057e5 to
721de91
Compare
| @retry_check(max_tries=12, retry_interval=5) | ||
| @retry_check(12, 5) |
There was a problem hiding this comment.
what's the reason for this change?
There was a problem hiding this comment.
it was mismatched with the actual naming of the parameters
def retry_check(max_tries: int = 5, retry_interval_seconds: int = 1)
should I instead correct and keep the named arguments?
There was a problem hiding this comment.
I think I'd keep the named arguments, but I leave it up to you to decide which is better.
There was a problem hiding this comment.
| command = ( | ||
| f"powershell -Command \"if ((Test-Path -LiteralPath '{directory_path}' -PathType Container) " | ||
| f"-and (Get-ChildItem -LiteralPath '{directory_path}' -Force | Select-Object -First 1)) " | ||
| f"{{ exit 0 }} else {{ exit 1 }}\"" | ||
| ) | ||
|
|
||
| exit_code, _ = self.exec_run(command) |
| [tool.setuptools] | ||
| package-dir = {"" = "src"} | ||
| packages = ["minifi_test_framework"] | ||
|
|
||
| [tool.setuptools.packages.find] | ||
| where = ["src"] | ||
| include = ["minifi_test_framework*"] | ||
|
|
There was a problem hiding this comment.
this is required for wheel building
| @retry_check(max_tries=12, retry_interval=5) | ||
| @retry_check(12, 5) |
There was a problem hiding this comment.
it was mismatched with the actual naming of the parameters
def retry_check(max_tries: int = 5, retry_interval_seconds: int = 1)
should I instead correct and keep the named arguments?
2 participants
This PR allows windows based docker containers to run the behave test suite with some limitations:
So this is only the MVP for this feature, but it is still a huge help for future developments especially for using it to develop external extensions using the upcoming C api. It cuts down the local verification time.
I've also replaced the previous m2crypto based ssl_utils with the industry standard cryptography, this should help with the setup on macs and windows systems (m2crypto was quite difficult to install on these systems)
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.