MINOR:Remove explicit flushes from RocksDBStores#21871
Merged
bbejeck merged 4 commits intoapache:trunkfrom Mar 31, 2026
Merged
Conversation
…ts ColumnFamily. Also, these stores use a RocksDB atomic flush to guarantee consistency between the default and offsets ColumnFamilies. As described in KIP-1035, this new behavior enables RocksDB stores to avoid explicitly flushing the memtables to the SST files
nicktelford
approved these changes
Mar 25, 2026
bbejeck
changed the title
bbejeck
approved these changes
Mar 30, 2026
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
Thanks @eduwercamacaro - LGTM with one minor comment
|
|
||
| accessor.commit(dbAccessor, offsets); | ||
|
|
||
| verify(dbAccessor).flush(oldCF, newCF, offsetsCF); |
Member
There was a problem hiding this comment.
Should we add another assertion here? Otherwise it's an empty test.
Contributor
Author
There was a problem hiding this comment.
I believe it is safe to remove this test entirely because the flush operation has been removed. Instead, the CF accessors now do commits, and we already test that in the AbstractColumnFamilyAccessorTest
Member
|
@eduwercamacaro after merging the other KIP-1035 PRs this now has merge conficts |
Member
Member
|
Merged #21871 into trunk |
bbejeck
pushed a commit
that referenced
this pull request
Mar 31, 2026
RocksDBStores now manage their own offsets by storing them in a `offsets` ColumnFamily. Also, these stores use a RocksDB atomic flush to guarantee consistency between the default and offsets ColumnFamilies. As described in KIP-1035, this new behavior enables RocksDB stores to avoid explicitly flushing the memtables to the SST files. This is a follow-up PR for #21578 we can now implement this because KAFKA-19712 is solved. Reviewers: NIck Telford <nick.telford@gmail.com>, Bill Bejeck <bbejeck@apache.org>
Member
|
cherry-picked to 4.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RocksDBStores now manage their own offsets by storing them in a
offsetsColumnFamily. Also, these stores use a RocksDB atomic flush toguarantee consistency between the default and offsets ColumnFamilies. As
described in KIP-1035, this new behavior enables RocksDB stores to avoid
explicitly flushing the memtables to the SST files.
This is a follow-up PR for #21578 we
can now implement this because KAFKA-19712 is solved.
Reviewers: NIck Telford nick.telford@gmail.com, Bill Bejeck
bbejeck@apache.org