IGNITE-28037 Fix deleted key prefix for distributed config#7697
Open
ivanzlenko wants to merge 2 commits intoapache:mainfrom
Open
IGNITE-28037 Fix deleted key prefix for distributed config#7697ivanzlenko wants to merge 2 commits intoapache:mainfrom
ivanzlenko wants to merge 2 commits intoapache:mainfrom
Conversation
ivanzlenko
commented
Mar 3, 2026
...figuration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationRegistry.java
Show resolved
Hide resolved
sashapolo
reviewed
Mar 3, 2026
|
|
||
| @Override | ||
| protected String getNodeBootstrapConfigTemplate() { | ||
| return NODE_BOOTSTRAP_CFG_TEMPLATE.substring(0, NODE_BOOTSTRAP_CFG_TEMPLATE.lastIndexOf('}')) |
Contributor
There was a problem hiding this comment.
I prefer the approach used by other tests, like ItIgniteStartTest
sashapolo
reviewed
Mar 3, 2026
| @@ -0,0 +1,2 @@ | |||
| org.apache.ignite.internal.configuration.TestLocalDeletedPrefixConfigurationModule | |||
| org.apache.ignite.internal.configuration.TestDistributedDeletedPrefixConfigurationModule No newline at end of file | |||
Contributor
Author
There was a problem hiding this comment.
We need to enable a check somewhere >:(
Contributor
Author
There was a problem hiding this comment.
If I find one I enable it in this PR. Non-discussable
Contributor
There was a problem hiding this comment.
We have this check enabled in checkstyle, but it probably only works for java files
Contributor
Author
There was a problem hiding this comment.
Yeah, or at least if files have an extension
sashapolo
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-28037