IGNITE-27373 DB API Driver 3: Add tests with GIL disabled#7683
Merged
IGNITE-27373 DB API Driver 3: Add tests with GIL disabled#7683
Conversation
There was a problem hiding this comment.
Pull request overview
Adds CI coverage and stress tests for the Python DB-API driver under Python 3.14’s free-threaded (GIL-disabled) mode, and updates infrastructure/configuration to run those scenarios.
Changes:
- Extend tox/TeamCity configuration to run an additional
py314t(no-GIL) test environment. - Add a new concurrency-focused pytest suite for the DB-API driver and adjust test fixtures for better isolation.
- Update DB-API
threadsafetylevel and refresh Python test dependencies.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/platforms/python/dbapi/tox.ini | Adds py314t tox env and GIL-disabled precheck. |
| modules/platforms/python/dbapi/tests/test_concurrency.py | New concurrency test suite intended to validate thread-safety (incl. no-GIL runs). |
| modules/platforms/python/dbapi/tests/conftest.py | Makes generated table names unique per test invocation. |
| modules/platforms/python/dbapi/requirements/tests.txt | Updates pytest/teamcity-messages versions; removes some older test deps. |
| modules/platforms/python/dbapi/requirements/install.txt | Removes runtime dependency list (now empty). |
| modules/platforms/python/dbapi/pyignite_dbapi/init.py | Updates DB-API threadsafety value. |
| .teamcity/test/platform_tests/python_tests/PythonDbApiToxTest.kt | Refactors Python DB-API tox build type and adds pyenv update step. |
| .teamcity/test/platform_tests/python_tests/Project.kt | New TeamCity subproject for Python test build configurations (incl. no-GIL). |
| .teamcity/test/platform_tests/RunPythonTests.kt | New composite build to run all Python test configurations. |
| .teamcity/test/platform_tests/Project.kt | Wires the new Python subproject/composite into Platform Tests. |
| .teamcity/test/build_types/RunPlatformTests.kt | Updates platform composite to depend on the new Python composite build. |
Comments suppressed due to low confidence (1)
.teamcity/test/platform_tests/python_tests/PythonDbApiToxTest.kt:45
- The build step runs
git pullinside the agent'spyenvcheckout, making builds non-reproducible and potentially breaking at any time due to upstream changes. Prefer pinning pyenv/definitions to a known revision (or baking the needed Python versions into the agent image) instead of updating at build time.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ptupitsyn
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-27373
Runs of new tests: https://ci.ignite.apache.org/buildConfiguration/DevApacheIgnite3x_Platforms_Ignite27373dbapiUpgradeApacheIgnite3x_Test_PlatformTests_RunPythonTests/10128617?buildTab=dependencies&type=snapshot&mode=list