Skip to content

IGNITE-27373 DB API Driver 3: Add tests with GIL disabled#7683

Merged
isapego merged 14 commits intomainfrom
ignite-27373
Mar 1, 2026
Merged

IGNITE-27373 DB API Driver 3: Add tests with GIL disabled#7683
isapego merged 14 commits intomainfrom
ignite-27373

Conversation

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds CI coverage and stress tests for the Python DB-API driver under Python 3.14’s free-threaded (GIL-disabled) mode, and updates infrastructure/configuration to run those scenarios.

Changes:

  • Extend tox/TeamCity configuration to run an additional py314t (no-GIL) test environment.
  • Add a new concurrency-focused pytest suite for the DB-API driver and adjust test fixtures for better isolation.
  • Update DB-API threadsafety level and refresh Python test dependencies.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
modules/platforms/python/dbapi/tox.ini Adds py314t tox env and GIL-disabled precheck.
modules/platforms/python/dbapi/tests/test_concurrency.py New concurrency test suite intended to validate thread-safety (incl. no-GIL runs).
modules/platforms/python/dbapi/tests/conftest.py Makes generated table names unique per test invocation.
modules/platforms/python/dbapi/requirements/tests.txt Updates pytest/teamcity-messages versions; removes some older test deps.
modules/platforms/python/dbapi/requirements/install.txt Removes runtime dependency list (now empty).
modules/platforms/python/dbapi/pyignite_dbapi/init.py Updates DB-API threadsafety value.
.teamcity/test/platform_tests/python_tests/PythonDbApiToxTest.kt Refactors Python DB-API tox build type and adds pyenv update step.
.teamcity/test/platform_tests/python_tests/Project.kt New TeamCity subproject for Python test build configurations (incl. no-GIL).
.teamcity/test/platform_tests/RunPythonTests.kt New composite build to run all Python test configurations.
.teamcity/test/platform_tests/Project.kt Wires the new Python subproject/composite into Platform Tests.
.teamcity/test/build_types/RunPlatformTests.kt Updates platform composite to depend on the new Python composite build.
Comments suppressed due to low confidence (1)

.teamcity/test/platform_tests/python_tests/PythonDbApiToxTest.kt:45

  • The build step runs git pull inside the agent's pyenv checkout, making builds non-reproducible and potentially breaking at any time due to upstream changes. Prefer pinning pyenv/definitions to a known revision (or baking the needed Python versions into the agent image) instead of updating at build time.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@isapego isapego requested a review from ptupitsyn February 27, 2026 09:35
@isapego isapego merged commit 21ddb58 into main Mar 1, 2026
21 of 29 checks passed
@isapego isapego deleted the ignite-27373 branch March 1, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants