Core: Fix useSnapshotSchema logic and projection in RESTTableScan#15609
Open
singhpk234 wants to merge 3 commits intoapache:mainfrom
Open
Core: Fix useSnapshotSchema logic and projection in RESTTableScan#15609singhpk234 wants to merge 3 commits intoapache:mainfrom
singhpk234 wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
Author
|
working on adding a test for this |
The useSnapshotSchema determination previously compared snapshot IDs, which was incorrect. The real distinction is branch (false) vs tag/direct snapshot ID (true). This is now tracked via a field that is set in overridden useRef() and useSnapshot() methods. The projection code previously only selected top-level field names, missing nested fields. Now uses TypeUtil.getProjectedIds() matching the pattern in SnapshotScan.
sfc-gh-prsingh
force-pushed
the
fix/rest-table-scan-snapshot-schema-and-projection
branch
from
b7c9b4b to
ec39661
Compare
Set useSnapshotSchema on this before calling super, letting newRefinedScan propagate the value to the new instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The useSnapshotSchema determination previously compared snapshot IDs, which was incorrect. The real distinction is branch (false) vs tag/direct snapshot ID (true). This is now tracked via a field that is set in overridden useRef() and useSnapshot() methods.
The projection code previously only selected top-level field names, missing nested fields. Now uses TypeUtil.getProjectedIds() matching the pattern in SnapshotScan.