Core: Simplify RESTTableScan by removing catalog internals#15595
Draft
singhpk234 wants to merge 1 commit intoapache:mainfrom
Draft
Core: Simplify RESTTableScan by removing catalog internals#15595singhpk234 wants to merge 1 commit intoapache:mainfrom
singhpk234 wants to merge 1 commit intoapache:mainfrom
Conversation
- Remove redundant fields (table, operations, tableIO) from RESTTableScan - Replace catalogProperties + hadoopConf with a FileIO factory function - Pre-compute resource paths instead of passing ResourcePaths + TableIdentifier - Replace Set<Endpoint> with supportsAsync/supportsCancel/supportsFetchTasks booleans - Change headers from Map to Supplier for consistency with RESTTable - Fix newRefinedScan to not propagate plan-scoped FileIO - Fix cleanupPlanResources to always invalidate tracker
rdblue
reviewed
Mar 12, 2026
| Endpoint.check(supportedEndpoints, Endpoint.V1_FETCH_TABLE_SCAN_PLAN); | ||
| Preconditions.checkState( | ||
| supportsAsync, | ||
| "Invalid plan status SUBMITTED: server does not support async scan planning"); |
Contributor
There was a problem hiding this comment.
SUBMITTED is not a valid status. It is submitted and I think it is important to be consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #15561 (comment)