fix: Interpret s3tables warehouse as table_location not metadata loca…

[emkornfield]

Which issue does this PR close?

AWS Docs state:

When you create a table, Amazon S3 automatically generates a warehouse location for the table. This is a unique S3 location that stores objects associated with the table. The following example shows the format of a warehouse location:

s3://63a8e430-6e0b-46f5-k833abtwr6s8tmtsycedn8s4yc3xhuse1b--table-s3

We were previously interpreting this as as a metadata location (i.e. the path to the metadata.json file), this changes the code use it as a table location.

• Closes bug: Incorrect interpretation of S3 create tables warehouse field #2114

What changes are included in this PR?

Change how we construct the MetadataLocation object.

Are these changes tested?

There never appears to have been a test, and I don't have an AWS account to verify this.

[emkornfield]

@CTTY @flaneur2020 thoughs on this change?

[CTTY]

Hi @emkornfield , this fix makes sense to me. Maybe we can add a test to cover it?

[emkornfield]

Hi @emkornfield , this fix makes sense to me. Maybe we can add a test to cover it?

I'm not really sure what a test would do here. we can try to mock the service with the expected value, but I'm not sure that gives us much confidence? If we think mocking does add value, I can look into doing it.