Add catalog properties for Catalog Tests#2982
Open
rambleraptor wants to merge 1 commit intoapache:mainfrom
Open
Add catalog properties for Catalog Tests#2982rambleraptor wants to merge 1 commit intoapache:mainfrom
rambleraptor wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
this does make tests a little nicer but also is it worth publicly exposing these methods just for making tests nicer? |
Fokko
reviewed
Feb 7, 2026
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Thanks @rambleraptor for extending the tests, these have shown to be very valuable.
I'm not sure about all the methods, I think they might be misleading and I think they add a lot of noise in the public API.
| except InvalidOperationException as e: | ||
| raise NamespaceNotEmptyError(f"Database {database_name} is not empty") from e | ||
| except MetaException as e: | ||
| except (MetaException, NoSuchObjectException) as e: |
Comment on lines
+756
to
+762
| @abstractmethod | ||
| def supports_slash_in_identifier(self) -> bool: | ||
| """Check if the catalog supports slash in identifier.""" | ||
|
|
||
| @abstractmethod | ||
| def supports_dot_in_identifier(self) -> bool: | ||
| """Check if the catalog supports dot in identifier.""" |
Contributor
There was a problem hiding this comment.
These might be misleading. For example, some implementations of the REST protocol might support this, while others not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
I've added a list of catalog-level properties to help the catalog tests. The goal is that the catalog tests work off of "features" and don't have exceptions for various catalogs.
As part of this, I discovered a discrepancy where HiveCatalog throws a different error than everyone else. I'm happy to change it back.
Are these changes tested?
Mostly a test change.
Are there any user-facing changes?