HIVE-29446: Remove reflective instance creation in iceberg-handler

[okumin]

What changes were proposed in this pull request?

Remove dynamic instantiation based on the Hive version. Most likely, the conditional instantiation was implemented when the related logic existed in Apache Iceberg, aiming to be effective for both Hive 2 and 3 with a single source code base. This is an example of Iceberg 1.3.0.
https://github.com/apache/iceberg/blob/apache-iceberg-1.3.0/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java

Why are the changes needed?

I think the reflections are no longer needed, and having them makes development a bit hard; e.g., code jumps are disabled.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit and integration test

[okumin]

I don't apply cosmetic changes suggested by Sonar Cloud in this PR because they are not directly related to where I changed.
https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6305&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true

[okumin]

This rename could be harmful if Hive includes an outdated Iceberg library. I don't think it happens.

[ayushtkn]

LGTM.

To me this looks safe and was in my bucket list. The rename thing also looks in general safe to me, but that is a public class unless anyone is using it or having a downstream client around, it is gonna break or they have to manage it if they want to support multiple versions.

Do you think we can skip the rename part?

[okumin]

@ayushtkn

The rename thing also looks in general safe to me, but that is a public class unless anyone is using it or having a downstream client around, it is gonna break or they have to manage it if they want to support multiple versions.
Do you think we can skip the rename part?

I agree. I reverted the renaming commit, and resolved a conflict with the latest master

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[okumin]

@ayushtkn Thank you! I hope this would make it easy to develop the Iceberg storage handler a bit