HIVE-29444: Log namenode address in testing scenarios #6304
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okumin
reviewed
Feb 7, 2026
| @SuppressFBWarnings(value = "EI_EXPOSE_REP2", justification = "intended") | ||
| public MiniDFSShim(MiniDFSCluster cluster) { | ||
| this.cluster = cluster; | ||
| LOG.info("Namenode address: {}", cluster.getNameNode().getNameNodeAddress()); |
Contributor
There was a problem hiding this comment.
It would fail when testing HA
https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-6304/1/tests/
Contributor
Author
There was a problem hiding this comment.
yeah, let me fix! (this was a quick patch and I was hoping that it would fail if needed :) )
Contributor
Author
There was a problem hiding this comment.
updated patch gives:
2026-02-10T04:22:45,615 INFO [main] shims.HadoopShimsSecure: Namenode nn1 (ns=minidfs) address: localhost/127.0.0.1:55017
2026-02-10T04:22:45,615 INFO [main] shims.HadoopShimsSecure: Namenode nn2 (ns=minidfs) address: localhost/127.0.0.1:55019
abstractdog
force-pushed
the
HIVE-29444
branch
from
923d747 to
ce63624
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?