Skip to content

Conversation

@shivaom02
Copy link
Contributor

What changes were proposed in this pull request?

  • Details:
    • After a successful DUMP, all the subsequent LOAD/DUMP which are skipped, should have the DUMP execution id.
    • Even the LOAD which runs while the DUMP is running should have this DUMP execution id, dues to which the LOAD was skipped.
    • This helps us identify a full DUMP -> SKIPPED LOAD?DUMP -> LOAD cycle.

Why are the changes needed?

So that we can identify a full replication cycle.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Copy link
Contributor

@pudidic pudidic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

* Details:
  * After a successful DUMP, all the subsequent LOAD/DUMP which are skipped, should have the DUMP execution id.
  * Even the LOAD which runs while the DUMP is running should have this DUMP execution id, dues to which the LOAD was skipped.
  * This helps us identify a full DUMP -> LOAD cycle.
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants