HIVE-29424: CBO plans should use histogram statistics for range predicates with a CAST #6293
+589
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cates with a CAST
|
thomasrebele
commented
Feb 4, 2026
Comment on lines
+228
to
+233
| if (range == null) | ||
| return cast; | ||
| if (range.minValue == null || Double.isNaN(range.minValue.doubleValue())) | ||
| return cast; | ||
| if (range.maxValue == null || Double.isNaN(range.maxValue.doubleValue())) | ||
| return cast; |
Contributor
Author
There was a problem hiding this comment.
I'll fix the 'if' construct must use '{}'s checkstyle warnings when updating the commit.
Comment on lines
+344
to
+345
| float[] boundaries = new float[] { Float.NEGATIVE_INFINITY, Float.POSITIVE_INFINITY }; | ||
| boolean[] inclusive = new boolean[] { true, true }; |
Contributor
Author
There was a problem hiding this comment.
I'll fix the '{' is followed by whitespace warnings when updating the PR.
| useFieldWithValues("f_numeric", VALUES2, KLL2); | ||
| float total = VALUES2.length; | ||
|
|
||
| { |
Contributor
Author
There was a problem hiding this comment.
Checkstyle warns about nested blocks, I'll refactor this when updating the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See HIVE-29424.
What changes were proposed in this pull request?
This PR adapts FilterSelectivityEstimator so that histogram statistics are used for range predicates with a cast.
I added many test cases to some cover corner cases. To get the ground truth, I executed queries with the predicates, see the resulting q.out file.
Why are the changes needed?
This PR allows the CBO planner to use histogram statistics for range predicates that contain a CAST around the input column.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests were added.