You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
❌ Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.3610%. Comparing base (e5dc35d) to head (5f7ec7b).
Has the API between JUnit 5 and 6 changed that much? It seems that JUnit Jupiter (covered by 5.x and 6.x) is what the groovy-test-junit5 module supports.
@eric-milles As per the "Bumping junit jupiter to version 6" email on the dev list, this was more about maintaining a convenience for users of just having to have groovy-test-junit6 as their dependency. Also, it is flagging that there will be changes across the different Jupiter versions. For instance, Jupiter 6 supports "Native Kotlin suspend Tests". Assuming we go ahead with async/await, I wanted to see whether a similar capability for Groovy async/await made sense. If it did, targeting Jupiter 6 would seem the right target. Also, we know JUnit 3/4 is now deprecated. If it is removed in Jupiter 7, we might again want changes for a groovy-test-junit7.
Having said all that, this seems to be one of those "could go either way" type decision points. Hence the email.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just bumps the version but I think we need to think about whether we want a groovy-test-junit6 module.
Update: latest verison of the PR adds a
groovy-test-junit6module. I plan to discuss on mailing list.