Conversation
|
@fresh-borzoni Appreciate your review here 🙏 |
21bab65 to
93a758f
Compare
|
@leekeiabstraction, it might be the case that we would need to get #351 merged first
|
|
That is fine. We can update this afterwards |
|
Still appreciate your early review on the other parts within this PR though! 🙏🏼 |
fresh-borzoni
left a comment
There was a problem hiding this comment.
@leekeiabstraction Ty for the PR.
quickly looked through. Left couple of comments, but still 'review in progress'
PTAL
| inline std::vector<fluss::ScanRecord> PollRecords(fluss::LogScanner& scanner, | ||
| size_t expected_count, | ||
| int timeout_seconds = 10) { | ||
| // We need to keep the ScanRecords alive since ScanRecord borrows from them |
There was a problem hiding this comment.
we shall remove it as it just returns empty vector in the end.
But it actually made me think - mb we should just use shared_ptr and I overcomplicated this pattern, it basically would be Arc from Rust.
prepared the fix for this: seems to work and better overall: #353
There was a problem hiding this comment.
Thanks, will update the test to use the latest APIs once #331 is also merged
fresh-borzoni
left a comment
There was a problem hiding this comment.
@leekeiabstraction finished review, left comments. PTAL
also once scan by buckets PR is merged - we need to add some tests for it
|
@leekeiabstraction Hi, since #331 is merge, maybe you need to update the pr |
8f82bd4 to
6b842b6
Compare
|
@fresh-borzoni Updated C++ IT to also use per-bucket scan records view. Appreciate if you can have a look. TY. |
Purpose
Linked issue: close #338
Brief change log