fix: enable ParquetFilterSuite tests for native_datafusion#3698
Closed
andygrove wants to merge 2 commits intoapache:mainfrom
Closed
fix: enable ParquetFilterSuite tests for native_datafusion#3698andygrove wants to merge 2 commits intoapache:mainfrom
andygrove wants to merge 2 commits intoapache:mainfrom
Conversation
Remove IgnoreCometNativeDataFusion tags from two ParquetFilterSuite tests that were disabled due to a CometNativeExec crash when executing without a serialized plan. The crash was fixed by PR apache#3511 which added a dedicated doExecuteColumnar() to CometNativeScanExec. The test assertions are already guarded by isCometEnabled/isCometScanOnly checks.
mbutrovich
approved these changes
Mar 16, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Thanks @andygrove! I love to see more tests running with native_datafusion!
Member
Author
|
moving to draft to avoid accidental merge - I need to rebase and merge each of the native_datafusion PRs individually to avoid corrupting the diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3320.
Rationale for this change
Two ParquetFilterSuite tests were disabled for native_datafusion mode due to a
CometNativeExec should not be executed directly without a serialized plancrash. This crash was fixed by #3511 which added a dedicateddoExecuteColumnar()toCometNativeScanExec, so these tests no longer need to be skipped.What changes are included in this PR?
Regenerated
dev/diffs/3.5.8.diffto removeIgnoreCometNativeDataFusiontags from two ParquetFilterSuite tests:Both tests have their
stripSparkFilterassertions already guarded byif (!isCometEnabled || isCometScanOnly), so they pass safely when Comet native execution is active.The other two tests from the issue were already resolved:
IgnoreCometNativeScan("cannot be pushed down")for a separate valid reasonHow are these changes tested?
By running the Spark SQL tests with Comet enabled in native_datafusion mode, which exercises the re-enabled ParquetFilterSuite tests.