fix: Introduce fluent pattern for StopWatch#1612
Closed
larshelge wants to merge 4 commits intoapache:masterfrom
Closed
fix: Introduce fluent pattern for StopWatch#1612larshelge wants to merge 4 commits intoapache:masterfrom
larshelge wants to merge 4 commits intoapache:masterfrom
Conversation
Member
|
-1: This PR breaks binary compatibility. If you really want this, you can create a Jira as a feature request for a future 4.0. |
Contributor
Author
|
Noted, that is okay @garydgregory . |
Member
|
Closing. Maybe for 4.0, which would be in a different package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces fluent pattern for
StopWatch. The goal is to improve readability and maintainability of code usingStopWatchby creating a sentence-like flow of operations.When using
StopWatchthe calling code gets a little verbose with operations on short, separate lines:A more fluent, readable and compact format could be: