Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Cassandra driver to make
AsyncioConnectionthe standard fallback event loop implementation, reflecting the removal ofasyncorein Python 3.12+. It also removes legacy compatibility checks and improves documentation and testing for the asyncio reactor.Event loop selection improvements:
AsyncioConnectionas the preferred fallback afterlibev, and as the default for Python 3.12+ whereasyncoreis no longer available. The selection order and documentation were revised accordingly. [1] [2] [3]Asyncio reactor modernization:
asyncio.run_coroutine_threadsafeand references to "experimental" status, reflecting thatAsyncioConnectionis now a mainstream option. Updated docstrings to clarify its role and requirements. [1] [2]_push_msgto useasync withfor modern asyncio syntax.initialize_reactor, avoiding unnecessary side effects.Testing improvements:
asyncioand replacedasynctest.TestSelectorwithMagicMockfor selector mocking. Added a new test for multi-timer validation with wider tolerances to account for asyncio's thread-based scheduling jitter. [1] [2] [3] [4]