Skip to content

[WIp] Alp encoding support#9372

Draft
sdf-jkl wants to merge 19 commits intoapache:mainfrom
sdf-jkl:alp
Draft

[WIp] Alp encoding support#9372
sdf-jkl wants to merge 19 commits intoapache:mainfrom
sdf-jkl:alp

Conversation

@sdf-jkl
Copy link
Contributor

@sdf-jkl sdf-jkl commented Feb 7, 2026

Which issue does this PR close?

Rationale for this change

check issue

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Feb 7, 2026
@alamb
Copy link
Contributor

alamb commented Feb 8, 2026

amaaazing

@sdf-jkl
Copy link
Contributor Author

sdf-jkl commented Feb 20, 2026

@alamb I worked with codex on replicating the c++ implementation reviewing commit by commit.

I'll do one final read myself, but this should be ready for initial review.

@alamb
Copy link
Contributor

alamb commented Feb 26, 2026

Thank you -- I will put this on my short list to reivew I was out last week

Copy link

@devanbenz devanbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

@sdf-jkl
Copy link
Contributor Author

sdf-jkl commented Mar 10, 2026

@devanbenz Sorry for taking so long to address your comments. I'll make sure to work on it this week!

@alamb
Copy link
Contributor

alamb commented Mar 11, 2026

The final spec is

Copy link

@devanbenz devanbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment about header regarding publication of spec.

@sdf-jkl
Copy link
Contributor Author

sdf-jkl commented Mar 12, 2026

Thanks @devanbenz, I finally addressed your reviews!

@devanbenz
Copy link

Thanks @devanbenz, I finally addressed your reviews!

Please cargo fmt the code 🫡

@sdf-jkl
Copy link
Contributor Author

sdf-jkl commented Mar 12, 2026

I swear I did 😿
Had to run

cargo fmt -p parquet --  --config skip_children=true `find ./parquet -name "*.rs" \! -name format.rs`

5e5c8d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Parquet] Prototype ALP encoding

3 participants