Skip to content

Conversation

@jbonofre
Copy link
Member

This PR adds the maxBrowsePageSize attribute to the JMX destination MBean.

As described in the Jira (AMQ-9775), the maxBrowsePageSize property can be set in the destination policies, in the broker.
I have several use cases where client applications are interested to get this metric (via JMX or REST with Jolokia):

  • know the browse paging limit to "optimize" paging/browsing on client side (faster)
  • get detail about the limit to "recommend" update on the paging limit

@jbonofre
Copy link
Member Author

I can add a test about this new JMX attribute.

@mattrpav
Copy link
Contributor

mattrpav commented Sep 25, 2025

@jbonofre please add a test for queue AND topic subscription recovery policy to catch regression

@jeanouii
Copy link
Contributor

The ticket refers to being able to provide a configuration option (maxBrowsePageSize), but the PR also includes the ability to update it. If this is intended, then we probably need to update the ticket and check the impact of updating the property at runtime. If it's not intended, we can I think remove the setter and not necessarly have tons of tests, it's read-only.

@jbonofre
Copy link
Member Author

My bad: the intent is really to just read (not update). I'm updating the PR accordingly.

@jbonofre
Copy link
Member Author

@jeanouii updated to just have read attribute.

Copy link
Contributor

@jeanouii jeanouii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is zero risk adding read-only feature to this property.
If we had to update the property, it would require checking the side effects and creating tests for regression. Other here, the tests would make very little added value.

@jeanouii jeanouii merged commit 7795308 into apache:main Feb 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants