Skip to content

Miduo/224 optimize login latecy#225

Open
Miduo666 wants to merge 2 commits intoanusii:devfrom
Miduo666:miduo/224_optimize_login_latecy
Open

Miduo/224 optimize login latecy#225
Miduo666 wants to merge 2 commits intoanusii:devfrom
Miduo666:miduo/224_optimize_login_latecy

Conversation

@Miduo666
Copy link
Contributor

@Miduo666 Miduo666 commented Mar 2, 2026

Pull Request Details

What issue does this PR address

  • [Description]

Associated Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

  • Screenshots included in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@gjwgit
Copy link
Contributor

gjwgit commented Mar 5, 2026

Thanks @Miduo666.

Please fix the conflict and merge the latest dev.

Ask copilot to review.

@Miduo666
Copy link
Contributor Author

Miduo666 commented Mar 6, 2026

Thanks @Miduo666.

Please fix the conflict and merge the latest dev.

Ask copilot to review.

Hi @gjwgit
I'm currently having issues requesting Copilot for the PR. Could you please trigger the Copilot review on your end?

Also, just a quick heads-up: the code depends on the new solidpod package (which is still in PR). Copilot might throw an error like The named parameter 'wasAlreadyLoggedIn' isn't defined. because it hasn't seen the updated definitions in the pending package PR yet

@Miduo666
Copy link
Contributor Author

Miduo666 commented Mar 6, 2026

Also I can not request Copilot in Solidpod and Solid_auth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants