fix: remove existing marketplaces before adding to ensure fresh installation #889
Open
csy1204 wants to merge 2 commits intoanthropics:mainfrom
Open
fix: remove existing marketplaces before adding to ensure fresh installation #889csy1204 wants to merge 2 commits intoanthropics:mainfrom
csy1204 wants to merge 2 commits intoanthropics:mainfrom
Conversation
To ensure marketplaces are always up-to-date: 1. Get list of installed marketplaces via 'claude plugin marketplace list' 2. Parse output to extract names (lines starting with ❯) 3. Remove all existing marketplaces 4. Add the new marketplaces fresh Also added comprehensive tests for marketplace removal functionality. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ashwin-ant
previously approved these changes
Feb 1, 2026
Collaborator
|
@csy1204 mind fixing the type error? |
Replace fragile arrow (❯) symbol parsing with structured JSON output from `claude plugin marketplace list --json` command. This approach is: - HUD-agnostic: Works regardless of terminal/HUD styling - Robust: Won't break if CLI output format changes - Type-safe: Properly typed MarketplaceEntry interface Also fixes TypeScript type error in test mock function signature. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
@ashwin-ant Fixed! Also switched to using --json flag for marketplace list command, which is more reliable than parsing the arrow symbols. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue on self-hosted runners where the Claude Code action fails with "Marketplace already installed" error because marketplaces from previous workflow runs persist in the runner's environment (
~/.claude/).Changes
Before adding marketplaces, the action now:
claude plugin marketplace list --jsonto get installed marketplacesclaude plugin marketplace removeKey Improvement: JSON Output Instead of Arrow Parsing
Before (fragile):
Configured marketplaces:
❯ marketplace-name
Source: Git (url)
Parsing arrow (
❯) symbols is fragile and dependent on CLI display formatting.After (robust):
[ { "name": "marketplace-name", "source": "git", "url": "https://example.com/repo.git", "installLocation": "/root/.claude/plugins/marketplaces/marketplace-name" } ]Using --json flag provides structured output that:
Test Plan
Files Changed