Merged
Conversation
Signed-off-by: Elijah Swift <Elijah.Swift@IBM.com>
Signed-off-by: Elijah Swift <Elijah.Swift@IBM.com>
Signed-off-by: Elijah Swift <Elijah.Swift@IBM.com>
Signed-off-by: Elijah Swift <Elijah.Swift@IBM.com>
Signed-off-by: Elijah Swift <Elijah.Swift@IBM.com>
Signed-off-by: Elijah Swift <Elijah.Swift@IBM.com>
lcarcaramo
reviewed
Mar 9, 2026
lcarcaramo
reviewed
Mar 9, 2026
Signed-off-by: Elijah Swift <Elijah.Swift@IBM.com>
Signed-off-by: Elijah Swift <Elijah.Swift@IBM.com>
lcarcaramo
reviewed
Mar 10, 2026
lcarcaramo
reviewed
Mar 10, 2026
lcarcaramo
reviewed
Mar 10, 2026
Signed-off-by: Elijah Swift <Elijah.Swift@IBM.com>
lcarcaramo
reviewed
Mar 10, 2026
Signed-off-by: Elijah Swift <Elijah.Swift@IBM.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Issue Reference
Issue: fixes #30
💻 What does this address?
There are valid use-cases for filtering based on an empty string in a specific value/location
📟 Implementation Details
Removed the check against empty string filters. Added translation to consider empty strings as "null" filters or filters looking for empty strings.
📋 Is there a test case?
Added positive tests to validate that empty string filters (used in all 3 ways) function. Changed test to validate that null filter failed to check a non-string case