Some housekeeping changes and new script to make regression testing easier#54
Merged
fred-lefebvre merged 2 commits intoamazonlinux:mainfrom Apr 2, 2026
Merged
Conversation
|
|
||
| #print standard metric | ||
| function print_normal_metric() { | ||
| metric_path=$2 |
Member
Author
There was a problem hiding this comment.
There is no word splitting or glob expansion on the right-hand side of variable assignments. metric_path="$2" is always equivalent to metric_path=$2 in this case.
|
|
||
| #print block-device-mapping | ||
| function print_block-device-mapping() | ||
| function print_block_device_mapping() |
Contributor
There was a problem hiding this comment.
LGTM! amazon-ec2-utils.spec and its %changelog were not updated in this PR. Will there be a follow-up PR ?
Member
Author
There was a problem hiding this comment.
Yes. I'll update the spec file and version with upcoming functional changes
saiharsha1994
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Housekeeping changes to
ec2-metadata:Add a new tests/capture-output.sh for regression testing
ec2-metadataTesting
tests/capture-output.shbefore changestests/capture-output.shafter changesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.