Skip to content

Silence error on lock attempt #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeysk2012 merged 1 commit into from
Mar 16, 2026
Merged

Silence error on lock attempt #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,8 +643,8 @@ register_networkd_reloader() {
# If the redirect fails, most likely because the target file
# already exists and -o noclobber is in effect, $? will be set
# nonzero. If it succeeds, it is set to 0
echo $$ > "${lockfile}"
# shellcheck disable=SC2320
2>/dev/null echo $$ > "${lockfile}"
Copy link
Copy Markdown

@saiharsha1994 saiharsha1994 Mar 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have prefered echo $$ > "${lockfile}" 2>/dev/null or { echo $$ > "${lockfile}"; } 2>/dev/null as they are easier to read

# shellcheck disable=SC2320
registered=$?
[ $registered -eq 0 ] && break
sleep 0.1
Expand Down
Loading