Conversation
This commit addresses potential memory leaks in `SettingsFragment` by properly managing `OnPropertyChangedCallback` listeners.
This commit refactors the management of `OnPropertyChangedCallback` instances to prevent potential memory leaks. Anonymous callbacks have been replaced with class properties, which are now correctly added in `start()` or `onCreateView()` and removed in corresponding lifecycle methods like `stop()` or `onDestroyView()`. Key changes: - Replaced anonymous `OnPropertyChangedCallback` implementations with property-based callbacks across multiple fragments and ViewModels (`BrowserFragment`, `BaseWebTabFragment`, `ProxiesFragment`, `MainActivity`, `VideoDetectionTabViewModel`, `WebTabViewModel`, `GlobalVideoDetectionModel`). - Ensured callbacks are removed in the appropriate lifecycle methods (`onDestroyView`, `stop`) to avoid retaining references to destroyed views or components. - In `VideoInfoAdapter`, a `TextWatcher` is now managed to prevent it from being added multiple times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.