Fix gutter line-number alignment with editor text#320
Open
FeodorFitsner wants to merge 1 commit intoakvelon:mainfrom
Open
Fix gutter line-number alignment with editor text#320FeodorFitsner wants to merge 1 commit intoakvelon:mainfrom
FeodorFitsner wants to merge 1 commit intoakvelon:mainfrom
Conversation
- normalize shared content padding via CodeField.padding - remove duplicated vertical paddings between gutter and TextField - use strut-based line height for code and gutter numbers - keep popup offsets consistent with new padding model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes vertical misalignment between gutter line numbers and code text in
CodeField.Fixes: #215, #312
Gutter and editor were using different/duplicated vertical spacing paths, which caused numbers to drift from code lines.
Changes
Files changed
lib/src/code_field/code_field.dartlib/src/gutter/gutter.dartValidation
03.change_language_theme).dart analyze lib/src/code_field/code_field.dart lib/src/gutter/gutter.dartflutter test test/src/code_field/code_controller_shortcut_test.dart