Conversation
nit23uec
reviewed
Mar 9, 2026
| const { | ||
| warmupDelayMs = isOptimized ? 750 : 0, // milliseconds | ||
| maxRetries = 3, | ||
| maxRetries = 5, |
Contributor
There was a problem hiding this comment.
Please retry at a delay of 2 sec with a max retry count of 8
Contributor
Author
There was a problem hiding this comment.
I am a bit concerned that adding a retry delay of 2 sec might result in more api timeouts (16s time breach) since we wait for API call also for 5s max. I have increased it to 1.5s for now, let me know your thoughts.
|
This PR will trigger a patch release when merged. |
nit23uec
approved these changes
Mar 19, 2026
solaris007
pushed a commit
that referenced
this pull request
Mar 25, 2026
## [@adobe/spacecat-shared-tokowaka-client-v1.12.2](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-tokowaka-client-v1.12.1...@adobe/spacecat-shared-tokowaka-client-v1.12.2) (2026-03-25) ### Bug Fixes * optimize preview api ([#1412](#1412)) ([3efb9de](3efb9de))
Member
|
🎉 This PR is included in version @adobe/spacecat-shared-tokowaka-client-v1.12.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!