fix(#1357): Gracefully handle missing pnpm installation during cache#1478
Open
Satishchoudhary94 wants to merge 1 commit intoactions:mainfrom
Open
fix(#1357): Gracefully handle missing pnpm installation during cache#1478Satishchoudhary94 wants to merge 1 commit intoactions:mainfrom
Satishchoudhary94 wants to merge 1 commit intoactions:mainfrom
Conversation
… cache This change prevents the action from failing immediately when pnpm is specified in packageManager but not yet installed (e.g., when using corepack). Changes: - Add isPackageManagerInstalled() function to check if a package manager exists - Update restoreCache to skip caching with a warning if package manager not found - Update cachePackages to skip cache save with a warning if package manager not found - This allows workflows to continue instead of failing - Users can either install pnpm first or disable caching with package-manager-cache: false Fixes actions#1357 Related: actions#1357
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
packageManager: pnpmwas set in package.json but pnpm wasn't installed yet(e.g., when using corepack), the action failed immediately with:
Solution
Added package manager installation check before caching. If package manager isn't found,
the action logs a warning and skips caching instead of failing.
Changes
isPackageManagerInstalled()function to check if tool exists on PATHrestoreCache()to skip with warning if package manager not foundcachePackages()to skip with warning if package manager not foundTesting
Fixes #1357