Open
Conversation
- Only enable package cache when the cache feature is availiable - We don't read "package.json" if previous version "cache" field is used
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the caching logic in the main setup-node workflow to improve performance and properly guard cache functionality. The changes ensure package cache is only enabled when the cache feature is available and avoid unnecessary package.json reads when the cache field is explicitly specified.
- Only enable package manager caching when the cache feature is available by wrapping logic with
isCacheFeatureAvailable() - Defer reading package.json until needed by moving
getNameFromPackageManagerField()call inside conditional blocks - Restructure cache logic to prioritize explicit cache input over automatic package manager detection
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The PR follows #1348 with a bugfix and a very slight performance improvement.
package-manager-cachelogic is not guarded byisCacheFeatureAvailable(), the PR fixes this.package.jsonif the previous version'scacheconfig is usedRelated issue:
Check list: