feat(node-version-file): Add node-version-file support for use-node-version in .npmrc files#1253
Open
kyle-leonhard wants to merge 8 commits intoactions:mainfrom
Open
feat(node-version-file): Add node-version-file support for use-node-version in .npmrc files#1253kyle-leonhard wants to merge 8 commits intoactions:mainfrom
kyle-leonhard wants to merge 8 commits intoactions:mainfrom
Conversation
Author
|
Hi @aparnajyothi-y , when you get a chance, please take a look! I forked this from #1149. |
2b82224 to
edb404f
Compare
2 tasks
Author
|
Hi @aparnajyothi-y or @priya-kinthali, apologies for the follow ups, could I trouble you to peek at this PR? |
|
not sure if this is best suited for a separate PR, but pnpm also supports this setting via |
Author
|
Hi @aparnajyothi-y or @priya-kinthali, apologies for the follow ups, could I trouble you to peek at this PR or suggest a reviewer? |
Author
|
Hey @HarithaVattikuti, any chance I can nag you to take a look at this PR? |
Author
|
@aparnajyothi-y can I nag you to give this PR a look? |
7f7a881 to
cd344b7
Compare
|
There is also: executionEnv.nodeVersion field of package.json and #1255 It is just a mess … |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add
node-version-filesupport for determining the Node version from theuse-node-versionkey of a.npmrcfile. See the PNPM docs.Here's an example
.npmrcfile:Related issue:
Resolves #1130
Check list: