Fix: correct error handling for non-string keys in YAML validation#186
Open
kfess wants to merge 1 commit intoactions:mainfrom
Open
Fix: correct error handling for non-string keys in YAML validation#186kfess wants to merge 1 commit intoactions:mainfrom
kfess wants to merge 1 commit intoactions:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes error handling during YAML validation by ensuring that non-string keys (null, boolean, numeric) are properly converted to strings.
- Replaces type assertion with explicit string conversion using String(), with special handling for null keys.
- Addresses JavaScript errors like "i.indexOf is not a function" by converting all scalar values to strings.
Comments suppressed due to low confidence (1)
workflow-parser/src/workflows/yaml-object-reader.ts:80
- Verify that using String() conversion properly handles numeric and boolean values as expected by the GitHub Actions runner behavior, and consider adding tests to cover these scenarios.
const key = scalarKey.value === null ? "" : String(scalarKey.value);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the incorrect error messages that appear when YAML files contain non-string keys (numbers, null, boolean values) in the GitHub Actions VSCode extension.
I think the issue is caused by the YAML parser assuming all keys are strings without proper type conversion.
Changes Made
Fix #185