Ajout du workflow CI TP et du fichier .nvmrc#2354
Ajout du workflow CI TP et du fichier .nvmrc#2354lFesselier wants to merge 3 commits intoactions:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new CI workflow pipeline and an .nvmrc file to specify the Node.js version. However, there are several critical issues that need to be addressed, including incorrect branch names and missing build steps.
- Adds a new GitHub Actions CI workflow (ci.yaml) to run tests and linting
- Adds an .nvmrc file specifying Node.js version 18
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| .nvmrc | Specifies Node.js version 18 for the project (inconsistent with existing workflows using v24) |
| .github/workflows/ci.yaml | New CI pipeline that runs dependency installation, tests, and linting on pull requests and pushes to master (should be "main") |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pull_request: | ||
| branches: [ main ] | ||
| push: | ||
| branches: [ main ] |
There was a problem hiding this comment.
The branch name "master" is incorrect for this repository. The repository uses "main" as its default branch, as seen in other workflow files like test.yml, check-dist.yml, and codeql-analysis.yml. This should be changed to "main" to ensure the workflow triggers correctly.
1 participant
No description provided.