backend: problems and submissions (plus other stuff)#113
Merged
Conversation
…ndpoint, leaderboard pipeline
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
RiyanMak
reviewed
Feb 22, 2026
| if err, ok := err.(services.BSGError); ok { | ||
| return echo.NewHTTPError(err.StatusCode, "Failed to end round. "+err.Error()) | ||
| } | ||
| if err, ok := err.(*services.BSGError); ok { |
Member
There was a problem hiding this comment.
EndRoundByRoomID never returns a pointer to the BSGError object its always just a copy of the BSGError object so you dont need this error check here
RiyanMak
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
promise this isn't actually 5k additions, 3,779 of them are just the problem data csv since we have nowhere else to put it
i broke this down into two prs, this one should be reviewed first, and the second has the frontend stuff for these backend changes
forgot to add vids will do later
what's left:
problem tags (array, tree, etc) currently don't do anything because we don't have that data for the problems
frontend integrations will need to be adapted to the new redesign
competitive logic
lots of testing, my testing was very limited