Scope webhook source attribution to scheduler flow and rely on TaskInfo.Command fallback#33
Closed
Scope webhook source attribution to scheduler flow and rely on TaskInfo.Command fallback#33
Conversation
Add support for BitLocker recovery keys: new Search-CIPPBitlockerKeys (search + enrich with Devices/ManagedDevices), Set-CIPPDBCacheBitlockerKeys (cache keys from Graph beta), and Invoke-ExecBitlockerSearch entrypoint to expose search via HTTP with tenant filtering and limits. Also register 'BitlockerKeys' in Push-CIPPDBCacheData and Search-CIPPDbData types so BitLocker data is included in caching and DB searches.
Replace references to UserPrincipalName with UPN when selecting mailbox properties and when passing Identity to Set-Mailbox. Updated three locations: NonCompliantMailboxes selection, Set-Mailbox Parameters (Identity), and the report Filtered selection. This ensures correct property access for mailbox objects that expose UPN.
Feat: Add JIT reason to alert messages (add/remove)
Allow callers to explicitly request no types by adding 'None' to the Types ValidateSet and handling it by setting $Types to an empty array. Maintains existing 'All' behavior (expands to Permissions, CalendarPermissions, Rules) and preserves default of 'All'. This enables callers to skip processing types when desired.
Extend the Graph API signIns filter to match both 'Authenticated SMTP' and 'SMTP' clientAppUsed values. This ensures successful SMTP authentication events (status/errorCode eq 0) are captured even when the clientAppUsed is reported as 'SMTP'. Updated the $uri in Get-CIPPAlertSmtpAuthSuccess.ps1 accordingly.
Copilot
AI
changed the title
[WIP] Refactor configuration endpoint and webhook schema
Simplify webhook standardization to a single config flag + unified root schema
Mar 3, 2026
Owner
|
@copilot we need the invoking alert/script name in the root object as well |
Author
Implemented in commit |
8c35d4b to
93e7c30
Compare
Copilot
AI
changed the title
Simplify webhook standardization to a single config flag + unified root schema
Prefer TaskInfo.Command as standardized webhook Source with APIName fallback
Mar 3, 2026
Copilot
AI
changed the title
Prefer TaskInfo.Command as standardized webhook Source with APIName fallback
Unify webhook notification schema metadata across non-alert senders
Mar 3, 2026
Copilot
AI
changed the title
Unify webhook notification schema metadata across non-alert senders
Propagate top-down webhook source for standardized notification payloads
Mar 3, 2026
Copilot
AI
changed the title
Propagate top-down webhook source for standardized notification payloads
Preserve top-down webhook source for scheduler alerts in standardized schema
Mar 3, 2026
7aa59ab to
fd35a9d
Compare
Copilot
AI
changed the title
Preserve top-down webhook source for scheduler alerts in standardized schema
Scope webhook source attribution to scheduler flow and rely on TaskInfo.Command fallback
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was around mixed webhook payload shapes: some alerts (e.g., scheduled offboarding) already carry task command context, while others from scheduler notifications are generic log alerts. This change narrows source attribution behavior to those two realities without introducing broader schema passthrough logic.
Scheduler webhook source propagation
Push-SchedulerCIPPNotificationsnow passes an explicit top-down source to webhook alerts via-WebhookSource $MyInvocation.MyCommand.Name.Source resolution remains minimal and predictable in
Send-CIPPAlertNew-CIPPWebhookRootSchema).TaskInfo.Commandremains in place when no explicitWebhookSourceis provided.Resulting behavior
TaskInfo.Command) keep command-based source fallback.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.