Update PlaneSelector to propagate trace summaries and support summary tags#459
Open
HokyeongNam wants to merge 1 commit intoWireCell:masterfrom
Open
Update PlaneSelector to propagate trace summaries and support summary tags#459HokyeongNam wants to merge 1 commit intoWireCell:masterfrom
HokyeongNam wants to merge 1 commit intoWireCell:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlaneSelector previously discarded trace summaries when copying traces
from the input frame to the output frame.
This caused mismatches between trace tag sizes and summary sizes in
downstream processing (eg Wire Cell Imaging), particularly when
PlaneSelector is used after signal processing steps that produce
trace summaries.
This PR propagates summaries through PlaneSelector in a manner similar
to ChannelSelector.
Key changes:
summary source tag corresponding to each trace tag