Fix sorting under View By Folder Structure.#3
Open
jimmywan wants to merge 1 commit intoWil-B:mainfrom
Open
Conversation
jimmywan
force-pushed
the
jw.fix_view_by_folder_structure_sort
branch
from
4a21321 to
8ddbdec
Compare
|
Actually the "View By Folder Structure" view must be sorted and the proper fix is here: -TT |
|
actually the current logic for "View By Folder" sorting is still wrong as it does not sort the album level like original Here is the correct fix for natural Windows Explorer sorting: I have updated the commit to the correct fix, you can update your original Library code as I fixed it already one week ago |
|
First time notifications works as intended hahaha Thanks for the heads up |
regorxxx
added a commit
to regorxxx/Library-Tree-SMP
that referenced
this pull request
Nov 21, 2025
- Fix sorting under View By Folder Structure by jimmywan Wil-B#3 - Changed how built-in icons paths are handled, using relative paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discovered in the Georgia-Reborn Thene, sorting under "View By Folder Structure" breaks if track titles have a numeric prefix. As far as I can tell, the file names are already returned by the file system in sorted order, so we can avoid doing additional sorting when folder structure view is enabled.
Fix taken from TT-ReBORN/Georgia-ReBORN#204