Skip to content

locker: animation to indicate auth failed on password and fingerprint#391

Open
trigg wants to merge 8 commits intomasterfrom
shake-it
Open

locker: animation to indicate auth failed on password and fingerprint#391
trigg wants to merge 8 commits intomasterfrom
shake-it

Conversation

@trigg
Copy link
Collaborator

@trigg trigg commented Mar 7, 2026

No description provided.

@trigg trigg assigned trigg and soreau Mar 9, 2026
@trigg
Copy link
Collaborator Author

trigg commented Mar 9, 2026

I forgot where we left on this. Was there anything more you thought needed doing? @soreau

@soreau
Copy link
Member

soreau commented Mar 9, 2026

I forgot where we left on this. Was there anything more you thought needed doing? @soreau

The commits I added took care of everything I wanted to see happen additionally, but I think we left off on selecting the same lockout tries and duration as the pin and fingerprint. So as long as you've updated that for the /etc/pam.d/wf-locker file, I think we should be good. 👍

@trigg
Copy link
Collaborator Author

trigg commented Mar 9, 2026

Alright thanks :)

@soreau soreau self-requested a review March 10, 2026 05:05
Copy link
Member

@soreau soreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, aside from changing the data/wf-locker file for pam. 👍

@@ -0,0 +1,2 @@
auth required pam_unix.so nodelay unlock_time=60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auth required pam_unix.so nodelay unlock_time=60
auth required pam_unix.so nodelay deny=3 unlock_time=10

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my testing we never trigger the unlock lockout because we missed the deny=3

But we do the lockout in our own software

@@ -0,0 +1,2 @@
auth required pam_unix.so nodelay unlock_time=60
account required pam_unix.so nodelay unlock_time=60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
account required pam_unix.so nodelay unlock_time=60
account required pam_unix.so nodelay deny=3 unlock_time=10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants