Skip to content

foreach_inplace(A,B) needs to fence on entry and exit #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evaleev merged 1 commit into from
Mar 16, 2026
Merged

foreach_inplace(A,B) needs to fence on entry and exit #540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/TiledArray/conversions/foreach.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,10 @@ inline std::enable_if_t<!is_dense_v<Policy>, void> foreach_inplace(
// Set the arg with the new array
left = detail::foreach<true, Op, LeftTile, LeftTile, Policy, RightTile>(
std::forward<Op>(op), shape_reduction, left, right);

// must also fence after to prevent remote ranks start work on unprocessed
// tiles
if (fence) left.world().gop.fence();
}

/// @}
Expand Down
Loading