Skip to content

feat: gracefully handle unknown resource overwrites #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cotovanu-cristian wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −5
Draft

feat: gracefully handle unknown resource overwrites #1364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/uipath/_cli/_utils/_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,14 @@ async def read_resource_overwrites_from_file(
.get("resourceOverwrites", {})
)
for key, value in resource_overwrites.items():
overwrites_dict[key] = ResourceOverwriteParser.parse(key, value)
try:
overwrites_dict[key] = ResourceOverwriteParser.parse(key, value)
except Exception as e:
logger.warning(
"Skipping unrecognized resource overwrite '%s': %s",
key,
e,
)

logger.debug(
"Loaded %d resource overwrite(s) from file %s",
Expand Down
8 changes: 4 additions & 4 deletions src/uipath/_cli/cli_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,10 @@ async def execute() -> None:
JsonLinesFileExporter(ctx.trace_file)
)

async with ResourceOverwritesContext(
lambda: read_resource_overwrites_from_file(ctx.runtime_dir)
):
with ctx:
with ctx:
async with ResourceOverwritesContext(
lambda: read_resource_overwrites_from_file(ctx.runtime_dir)
):
runtime: UiPathRuntimeProtocol | None = None
chat_runtime: UiPathRuntimeProtocol | None = None
factory: UiPathRuntimeFactoryProtocol | None = None
Expand Down