Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Twine upload step in the GitHub Actions publish.yml to install Twine at runtime and point to a new package registry endpoint.
- Install or upgrade
pipandtwinebefore uploading - Change the
--repository-urlto the GitHub Packages API for Python - Keep the existing
dist/*artifact path unchanged
Comments suppressed due to low confidence (1)
.github/workflows/publish.yml:34
- The repository URL is now pointing to the GitHub Packages API rather than the public PyPI legacy endpoint. If the intention is to publish to PyPI.org, change this to
https://upload.pypi.org/legacy/. If you mean to target GitHub Packages, consider renaming the job or step to reflect that.
--repository-url https://api.github.com/orgs/${{ github.repository_owner }}/packages/pypi/upload \
| run: | | ||
| twine upload \ | ||
| --repository-url https://upload.pypi.github.io/UCD-BDLab/BioNeuralNet \ | ||
| python -m pip install --upgrade pip twine |
There was a problem hiding this comment.
[nitpick] Installing pip and twine on every workflow run can slow down CI. Consider using actions/setup-python with a pre-cached environment or leveraging actions/cache to speed up dependency installation.
Member
Author
There was a problem hiding this comment.
that's actually not a bad suggestion for once.
Member
Author
|
All test checks have passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug related to publish.yml attempt 2