Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues in the GitHub Actions workflow for publishing packages to PyPI and GitHub Packages. The changes simplify the workflow trigger conditions and correct the repository URL for GitHub Packages publishing.
- Removes the release trigger and associated conditional logic to simplify workflow execution
- Updates the GitHub Packages repository URL to use the correct endpoint format
- Adds some formatting improvements with blank lines
| run: | | ||
| twine upload \ | ||
| --repository-url https://api.github.com/orgs/UCD-BDLab/packages/pypi/upload \ | ||
| --repository-url https://upload.pypi.github.io/UCD-BDLab/BioNeuralNet \ |
There was a problem hiding this comment.
The GitHub Packages repository URL appears to be incorrect. The correct format for GitHub Packages should be 'https://upload.pypi.org/legacy/' for PyPI or 'https://npm.pkg.github.com/OWNER/PACKAGE' for GitHub Packages. The current URL 'https://upload.pypi.github.io/UCD-BDLab/BioNeuralNet' does not match GitHub's documented endpoints.
| --repository-url https://upload.pypi.github.io/UCD-BDLab/BioNeuralNet \ | |
| --repository-url https://upload.pypi.org/legacy/ \ |
| @@ -34,14 +28,16 @@ jobs: | |||
| env: | |||
| TWINE_USERNAME: __token__ | |||
| TWINE_PASSWORD: ${{ secrets.GITHUB_TOKEN }} | |||
There was a problem hiding this comment.
Using GITHUB_TOKEN for publishing to GitHub Packages may not have sufficient permissions. Consider using a Personal Access Token (PAT) with 'packages:write' scope stored as a secret instead.
| TWINE_PASSWORD: ${{ secrets.GITHUB_TOKEN }} | |
| TWINE_PASSWORD: ${{ secrets.GITHUB_PACKAGES_PAT }} |
|
All test checks have passed. |
1 participant
Fix bug related to publish.yml