Break Variable into (Variable, Collection)#674
Merged
frankmcsherry merged 3 commits intoTimelyDataflow:master-nextfrom Feb 25, 2026
Merged
Break Variable into (Variable, Collection)#674frankmcsherry merged 3 commits intoTimelyDataflow:master-nextfrom
Variable into (Variable, Collection)#674frankmcsherry merged 3 commits intoTimelyDataflow:master-nextfrom
Conversation
Member
Author
|
Looking at the code, I think we can potentially remove |
frankmcsherry
force-pushed
the
variable_collection_split
branch
from
fbeb34c to
e21b1c3
Compare
antiguru
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An example of how we might partition
Variableinto the independent parts of 1. the collection to use in the recursive definition, and 2. the place to bind the recursive definition. This removes allCloneconstraints other than thenew_frommethod which needs to clone the "from" collection to subtract it in the next iteration.