Update github workflows

.github/workflows/deploy.yml

@@ -5,12 +5,15 @@ on:
     branches:
       - master
 
+concurrency:
+  group: deploy
+
 jobs:
   deploy:
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v6
-      - run: cargo install mdbook --version 0.4.44
+      - run: cargo install mdbook --version 0.5.2
       - name: Patch sample Cargo.toml versions
         run: |
           export DIFFERENTIAL_VERSION=$(cargo metadata --format-version 1 | jq -r '.packages[] | select(.name == "differential-dataflow") | .version')

.github/workflows/release-plz.yml

@@ -9,6 +9,9 @@ on:
     branches:
       - master
 
+concurrency:
+  group: release-plz
+
 jobs:
   release-plz:
     name: Release-plz

.github/workflows/test-timely-master.yml

@@ -36,7 +36,7 @@ jobs:
 
   notify:
     name: Notify failed build
-    if: failure() && github.event.pull_request == null
+    if: failure() && github.repository == 'TimelyDataflow/differential-dataflow'
     needs: [tests]
     permissions:
       contents: read

.github/workflows/test.yml

@@ -12,7 +12,7 @@ jobs:
         os:
           - ubuntu
           - macos
-          # - windows
+          - windows
         toolchain:
           - stable
           - 1.86
@@ -27,3 +27,17 @@ jobs:
         run: cargo test --workspace --all-targets
       - name: Cargo doc test
         run: cargo test --doc
+
+  # Check for clippy warnings
+  clippy:
+    name: Cargo clippy
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - uses: actions-rust-lang/setup-rust-toolchain@v1
+        with:
+          components: clippy
+      - name: Cargo clippy
+        run: cargo clippy --workspace --all-targets
+        env:
+          RUSTFLAGS: "" # Don't make test fail on clippy

Cargo.toml

@@ -26,6 +26,69 @@ columnar = { version = "0.11", default-features = false }
 timely = { git = "https://github.com/TimelyDataflow/timely-dataflow" }
 #timely = { path = "../timely-dataflow/timely/", default-features = false }
 
+[workspace.lints.clippy]
+type_complexity = "allow"
+option_map_unit_fn = "allow"
+wrong_self_convention = "allow"
+should_implement_trait = "allow"
+module_inception = "allow"
+
+#as_conversions = "warn"
+bool_comparison = "warn"
+borrow_interior_mutable_const = "warn"
+borrowed_box = "warn"
+builtin_type_shadow = "warn"
+clone_on_ref_ptr = "warn"
+crosspointer_transmute = "warn"
+dbg_macro = "warn"
+deref_addrof = "warn"
+disallowed_macros = "warn"
+disallowed_methods = "warn"
+disallowed_types = "warn"
+double_must_use = "warn"
+double_parens = "warn"
+duplicate_underscore_argument = "warn"
+excessive_precision = "warn"
+extra_unused_lifetimes = "warn"
+from_over_into = "warn"
+match_overlapping_arm = "warn"
+must_use_unit = "warn"
+mut_mutex_lock = "warn"
+needless_borrow = "warn"
+needless_pass_by_ref_mut = "warn"
+needless_question_mark = "warn"
+needless_return = "warn"
+no_effect = "warn"
+panicking_overflow_checks = "warn"
+partialeq_ne_impl = "warn"
+print_literal = "warn"
+redundant_closure = "warn"
+redundant_closure_call = "warn"
+redundant_field_names = "warn"
+redundant_pattern = "warn"
+redundant_slicing = "warn"
+redundant_static_lifetimes = "warn"
+same_item_push = "warn"
+shadow_unrelated = "warn"
+single_component_path_imports = "warn"
+suspicious_assignment_formatting = "warn"
+suspicious_else_formatting = "warn"
+suspicious_unary_op_formatting = "warn"
+todo = "warn"
+transmutes_expressible_as_ptr_casts = "warn"
+unnecessary_cast = "warn"
+unnecessary_lazy_evaluations = "warn"
+unnecessary_mut_passed = "warn"
+unnecessary_unwrap = "warn"
+unused_async = "warn"
+useless_asref = "warn"
+useless_conversion = "warn"
+useless_format = "warn"
+wildcard_in_or_patterns = "warn"
+write_literal = "warn"
+zero_divided_by_zero = "warn"
+zero_prefixed_literal = "warn"
+
 [profile.release]
 opt-level = 3
 debug = true

advent_of_code_2017/Cargo.toml

@@ -4,6 +4,9 @@ version = "0.1.0"
 authors = ["Frank McSherry <fmcsherry@me.com>"]
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 differential-dataflow = { workspace = true }
 timely = { git = "https://github.com/frankmcsherry/timely-dataflow" }

differential-dataflow/Cargo.toml

@@ -15,6 +15,9 @@ license = "MIT"
 readme = "../README.md"
 edition.workspace = true
 
+[lints]
+workspace = true
+
 [dev-dependencies]
 rand="0.4"
 itertools="^0.13"

dogsdogsdogs/Cargo.toml

@@ -10,6 +10,9 @@ documentation = "https://docs.rs/differential-dogs3"
 homepage = "https://github.com/TimelyDataflow/differential-dataflow"
 repository = "https://github.com/TimelyDataflow/differential-dataflow.git"
 
+[lints]
+workspace = true
+
 [dependencies]
 timely = { workspace = true }
 differential-dataflow = { workspace = true }

doop/Cargo.toml

@@ -5,6 +5,9 @@ authors = ["Frank McSherry <fmcsherry@me.com>"]
 edition.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 timely = {workspace = true}
 differential-dataflow = { workspace = true }

experiments/Cargo.toml

@@ -5,6 +5,9 @@ authors = ["Frank McSherry <fmcsherry@me.com>"]
 edition.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 core_affinity = "0.5.9"
 rand="0.3.13"

interactive/Cargo.toml

@@ -5,6 +5,9 @@ authors = ["Frank McSherry <fmcsherry@me.com>"]
 edition.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 bincode = "1"
 serde = { version = "1", features = ["derive"]}

mdbook/Cargo.toml

@@ -4,6 +4,9 @@ version = "0.0.0"
 edition.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 differential-dataflow = { path = "../differential-dataflow" }
 timely.workspace = true

server/Cargo.toml

@@ -5,6 +5,9 @@ authors = ["Frank McSherry <fmcsherry@me.com>"]
 edition.workspace = true
 publish = false
 
+[lints]
+workspace = true
+
 [dependencies]
 libloading = "0.8"
 differential-dataflow = { workspace = true }