Sanitize HTML in error responses to prevent reflected XSS#7849
Merged
nicholaspcr merged 2 commits intov3.36from Mar 6, 2026
Merged
Sanitize HTML in error responses to prevent reflected XSS#7849nicholaspcr merged 2 commits intov3.36from
nicholaspcr merged 2 commits intov3.36from
Conversation
halimi
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of https://github.com/TheThingsIndustries/lorawan-stack/pull/4828.
Sanitize error responses to prevent reflected XSS from user-supplied input that flows into gRPC error messages and error detail attributes.
Changes
sanitizingHTTPErrorHandlerinpkg/rpcserverthat HTML-escapes gRPC status messages before they are serialized to JSON, replacingruntime.DefaultHTTPErrorHandler.sanitizeAttributesandsanitizeAttributeValueinpkg/ttnpb/errors.goto HTML-escape string values in error detail attributes withinErrorDetailsToProto.pkg/rpcserver,pkg/ttnpb, andpkg/webhandlers.Testing
Steps
<script>instead of<script>.Results
All three tests pass. The error response body contains HTML-escaped entities and no raw
<script>tags.Regressions
messagefield in JSON error responses is now HTML-escaped, which may affect clients that display error messages as plain text (escaped entities like<would appear literally). This is the same behavior as the enterprise PR.Notes for Reviewers
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.