Added basic support for DNS cookies#56
Open
zbalkan wants to merge 6 commits intoTechnitiumSoftware:masterfrom
Open
Added basic support for DNS cookies#56zbalkan wants to merge 6 commits intoTechnitiumSoftware:masterfrom
zbalkan wants to merge 6 commits intoTechnitiumSoftware:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds DNS Cookie support to the TechnitiumLibrary DNS implementation per RFC 7873/9018. It introduces a new EDnsCookieOptionData class to handle EDNS(0) COOKIE parsing and validation, and updates the EDnsOption class to support null option data and handle COOKIE options during serialization/deserialization.
Changes:
- Added
EDnsCookieOptionDataclass for RFC 7873 DNS Cookie support with client (8 bytes) and optional server cookies (8-32 bytes) - Updated
EDnsOptionto handle COOKIE option code parsing and null data scenarios - Modified
EDnsOption.WriteTo()andSerializeTo()to support EDNS options with zero-length data
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| TechnitiumLibrary.Net/Dns/EDnsOptions/EDnsOption.cs | Added COOKIE case in parsing switch, null data handling in WriteTo/SerializeTo, and nullable UncompressedLength calculation |
| TechnitiumLibrary.Net/Dns/EDnsOptions/EDnsCookieOptionData.cs | New sealed class implementing DNS Cookie EDNS option with validation, serialization, and equality support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Okay, Copilot has some valid suggestions. I'll fix them tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds DNS Cookies support across TechnitiumLibrary EDNS(0) COOKIE parsing, server-side cookie generation/validation, and request/response handling per RFC 7873/9018.