[feat] Added library block to UMC setup#5
Open
poizzy wants to merge 3 commits intoTeamOpenIndustry:masterfrom
Open
[feat] Added library block to UMC setup#5poizzy wants to merge 3 commits intoTeamOpenIndustry:masterfrom
poizzy wants to merge 3 commits intoTeamOpenIndustry:masterfrom
Conversation
| } | ||
|
|
||
| if (library.isPath) { | ||
| depends.append(String.format("\t%s files('%s')", library.type, library.id)).append("\n"); |
Member
There was a problem hiding this comment.
We might have to deal with flatDir above 1.17 as files won't work on there anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to add libraries for UMC submods directly in the
umc.json. Highly inspired by TeamOpenIndustry/UniversalModCore#204. Before this PR is mergeable, we need to enable the shade plugin in the build.gradle template, and add some aditional variable tags.Usage: