fix(form-core): Resolve onSubmitInvalid not being called with invalid default values by Dhavanesh24cs412 · Pull Request #1997 · TanStack/form

Dhavanesh24cs412 · 2026-01-16T02:24:49Z

Remove stale canSubmit check that prevented onSubmitInvalid from being called
On first render, canSubmit was true even with invalid default values

Problem

When a form is initialized with invalid default values, the onSubmitInvalid callback was not being called on the first submission attempt. This occurred because an early canSubmit check in the _handleSubmit method would short-circuit the validation flow before reaching the proper validation logic.

Root Cause

The issue was located in packages/form-core/src/FormApi.ts in the _handleSubmit method. An early check:

if (!this.state.canSubmit && !this._devtoolsSubmissionOverride) {
  // Early return without proper validation
  return
}

This check was preventing the form from:

Calling validateAllFields('submit') to validate all fields
Executing the onSubmitInvalid callback when validation fails
Properly handling forms with invalid default values

Solution

Removed the stale early canSubmit check from the _handleSubmit method. The form now:

Proceeds directly to validateAllFields('submit')
Properly calls onSubmitInvalid when validation fails
Correctly handles submission attempts on forms with invalid default values
Still respects validation logic through proper checks after validation occurs

Changes Made

✅ Removed early canSubmit guard in _handleSubmit method
✅ Validation now properly executes on all submissions
✅ onSubmitInvalid callback is invoked when appropriate
✅ Fixes edge case with invalid default form values

Testing

This fix addresses the issue described in #1990 where forms with invalid default values were not triggering the onSubmitInvalid callback.

Closes #1990- Fixes: onSubmitInvalid not called when form is invalid with default values

🎯 Changes

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

…ck#1990) - Remove stale canSubmit check that prevented onSubmitInvalid from being called - On first render, canSubmit was true even with invalid default values - Proper validation checks after this point correctly handle onSubmitInvalid - Fixes: onSubmitInvalid not called when form is invalid with default values

changeset-bot · 2026-01-16T02:24:53Z

⚠️ No Changeset found

Latest commit: 570e59b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Dhavanesh24cs412 · 2026-01-16T02:41:33Z

This solution effectively addresses the issue where onSubmitInvalid wasn't being triggered for forms with invalid default values. By removing the early canSubmit check and allowing validation to execute properly, forms can now correctly invoke the callback even on initial submission. The approach maintains backward compatibility while fixing the edge case.

LeCarbonator · 2026-01-18T08:27:03Z

In what way is canSubmit stale? If you have errors present that are not resolved, why would a submission change that?

nx-cloud · 2026-01-18T08:27:04Z

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

_{To disable these notifications, a workspace admin can disable them in workspace settings.}

View your CI Pipeline Execution ↗ for commit 570e59b

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	❌ Failed	2m 14s	View ↗
`nx run-many --target=build --exclude=examples/**`	✅ Succeeded	33s	View ↗

☁️ Nx Cloud last updated this comment at 2026-01-18 08:51:50 UTC

pkg-pr-new · 2026-01-18T08:50:23Z

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1997

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1997

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1997

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1997

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1997

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1997

@tanstack/react-form-nextjs

npm i https://pkg.pr.new/@tanstack/react-form-nextjs@1997

@tanstack/react-form-remix

npm i https://pkg.pr.new/@tanstack/react-form-remix@1997

@tanstack/react-form-start

npm i https://pkg.pr.new/@tanstack/react-form-start@1997

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1997

@tanstack/solid-form-devtools

npm i https://pkg.pr.new/@tanstack/solid-form-devtools@1997

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1997

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1997

commit: 570e59b

Dhavanesh24cs412 · 2026-01-19T11:07:54Z

I would solve this issue by tonight! The 9 lines of code i deleted in my branch executed well once a run, i would double check and cinfigure the changes

Merge branch 'TanStack:main' into fix/1990-onSubmitInvalid-early-check

570e59b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(form-core): Resolve onSubmitInvalid not being called with invalid default values#1997

fix(form-core): Resolve onSubmitInvalid not being called with invalid default values#1997
Dhavanesh24cs412 wants to merge 2 commits intoTanStack:mainfrom
Dhavanesh24cs412:fix/1990-onSubmitInvalid-early-check

Dhavanesh24cs412 commented Jan 16, 2026

Uh oh!

changeset-bot bot commented Jan 16, 2026 •

edited

Loading

Uh oh!

Dhavanesh24cs412 commented Jan 16, 2026 •

edited

Loading

Uh oh!

LeCarbonator commented Jan 18, 2026

Uh oh!

nx-cloud bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jan 18, 2026

Uh oh!

Dhavanesh24cs412 commented Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Dhavanesh24cs412 commented Jan 16, 2026

Problem

Root Cause

Solution

Changes Made

Testing

🎯 Changes

✅ Checklist

🚀 Release Impact

Uh oh!

changeset-bot bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Dhavanesh24cs412 commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LeCarbonator commented Jan 18, 2026

Uh oh!

nx-cloud bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Nx Cloud AI Fix Eligible

Uh oh!

pkg-pr-new bot commented Jan 18, 2026

Uh oh!

Dhavanesh24cs412 commented Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Jan 16, 2026 •

edited

Loading

Dhavanesh24cs412 commented Jan 16, 2026 •

edited

Loading

nx-cloud bot commented Jan 18, 2026 •

edited

Loading